Blocks: Calendly block #14252

scruffian · 2019-12-17T11:47:17Z

This adds a new Jetpack block for Calendly.

Changes proposed in this Pull Request:

The block supports all the different embed options that Calendly offer, as well as pasting the embed code.

Screenshots:

Is this a new feature or does it add/remove features to an existing part of Jetpack?

Master Thread: pb5gDS-fs-p2

Testing instructions:

Enable Beta Blocks
Create a new post
Add a Calendly block
Paste in each of the following:

A Calendly URL
A Calendly URL without https://
The inline embed code
The popup widget embed code
The text widget embed code

Repeat the previous steps but customise the colours (requires a pro account)
Edit the block from the sidebar:

Styles
Hide event details
Update the block using the embed code

Check that the block renders correctly on the user's site

Using Calendly

To get the different embed codes from Calendly you will need a Calendly account:

Proposed changelog entry for your changes:

Add Calendly block

jetpackbot · 2019-12-17T11:49:17Z

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: February 11, 2020.
Scheduled code freeze: February 4, 2020

Generated by 🚫 dangerJS against e9969e2

glendaviesnz · 2020-01-09T01:41:50Z

One minor thing - if a user just highlights their link and cmd-v's it instead of clicking the 'copy' button, which they may not even realise is a copy button, then the embed fails as it is missing the https:// - would be better to allow the url with or without the https://

extensions/blocks/calendly/edit.js

glendaviesnz · 2020-01-09T03:21:19Z

Nice work 👍 Apart from the issue mentioned with the link without http it seemed to work well for me.

The only thing I couldn't work out is what difference the 'Hide event type details' was supposed to make - didn't seem to have any effect, but that may just be to do with how my calendly account is set up.

Would be good to add some unit tests for the likes of getUrlAndStyleFromEmbedCode & getNewAttributesFromUrl if the api for these is firmed up, and maybe these could be pulled out into a util module - but that is maybe a phase 2 job?

huguesvincent · 2020-01-09T10:42:00Z

then the embed fails as it is missing the https:// - be better to allow the url with or without the https://
thanks for spotting this @glendaviesnz

scruffian · 2020-01-13T17:41:44Z

'Hide event type details' does this:

Maybe this is a pro feature?

glendaviesnz · 2020-01-13T18:56:06Z

'Hide event type details' does this: Maybe this is a pro feature?

Working for me now - I had embedded the list of all events rather than a single event, so the toggle had no effect, but works when embedding a specific event.

jeherve

Is there a way we can make the link preview look a bit better?

Maybe we can do something to error out nicely when one does not paste a proper embed code (like for example another type of Calendly embed)?

extensions/blocks/calendly/attributes.js

extensions/blocks/calendly/calendly.php

extensions/blocks/calendly/index.js

extensions/blocks/calendly/test/utils.js

scruffian · 2020-01-15T12:35:59Z

I have addressed the major concerns on the PR. I would like to do some refactoring to reuse some code from the OpenTable PR, however, is it possible to merge this PR as is and follow with that in a future PR? IMO This would make the review process simpler.

extensions/blocks/calendly/edit.js

jeherve

This is looking good now. I'll merge it for now. I've opened issues for all issues that I think are left right now:

#14365
#14366
#14367
#14368

matticbot · 2020-01-16T14:35:36Z

Caution: This PR has changes that must be merged to WordPress.com
Hello scruffian! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D37786-code before merging this PR. Thank you!

* [not verified] Remove empty readme section * Initial changelog for 8.2 * Changelog: add #14220 * Changelog: add #14252 * Changelog: add #14291 * Changelog: add #14309 * Changelog: add #14304 * Changelog: add general connection log. * Changelog: add #14275 * Changelog: add #14313 * Changelog: add #14213 * Changelog: add #14357 * Add sync testing instructions * Add 8.1.1 changelog back See eeaafab and 61757eb * Changelog: add #14371 * Changelog: add #14386 * Changelog: add #14471 * Changelog: add #14325 * Changelog: add #14194 * Changelog: add #14340 * Changelog: add #14418 * Changelog: add #14417 * Changelog: add #14075 * Changelog: add #14467 * Changelog: add #14307 * Changelog: add #14326

scruffian added the [Status] In Progress label Dec 17, 2019

scruffian requested a review from a team December 17, 2019 11:47

scruffian self-assigned this Dec 17, 2019

matticbot added the Touches WP.com Files label Dec 17, 2019

jeherve added [Block] Calendly [Type] Feature Request [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Dec 17, 2019

jeherve changed the title ~~Add/calendly block~~ Blocks: new Calendly block Dec 17, 2019

huguesvincent added this to the 8.2 milestone Dec 18, 2019

scruffian force-pushed the add/calendly-block branch from eac03fb to 624ff3b Compare January 6, 2020 13:49

glendaviesnz reviewed Jan 9, 2020

View reviewed changes

extensions/blocks/calendly/edit.js Outdated Show resolved Hide resolved

glendaviesnz reviewed Jan 9, 2020

View reviewed changes

extensions/blocks/calendly/edit.js Outdated Show resolved Hide resolved

glendaviesnz reviewed Jan 9, 2020

View reviewed changes

extensions/blocks/calendly/edit.js Outdated Show resolved Hide resolved

glendaviesnz reviewed Jan 9, 2020

View reviewed changes

extensions/blocks/calendly/edit.js Outdated Show resolved Hide resolved

scruffian changed the title ~~Blocks: new Calendly block~~ Blocks: Calendly block Jan 13, 2020

scruffian added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Jan 13, 2020

scruffian force-pushed the add/calendly-block branch 2 times, most recently from 4318050 to 473c59e Compare January 13, 2020 20:42

jeherve requested changes Jan 14, 2020

View reviewed changes

jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jan 14, 2020

scruffian force-pushed the add/calendly-block branch from 1408c28 to 2f6c37a Compare January 15, 2020 11:49

scruffian force-pushed the add/calendly-block branch from d711c5c to d1edccc Compare January 15, 2020 12:37

Add caldendly block

594ff1e

scruffian force-pushed the add/calendly-block branch from d1b97b4 to 594ff1e Compare January 15, 2020 15:04

update the example

eae370e

jeherve requested changes Jan 15, 2020

View reviewed changes

extensions/blocks/calendly/edit.js Outdated Show resolved Hide resolved

fix wrong file name

e9969e2

jeherve approved these changes Jan 16, 2020

View reviewed changes

jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 16, 2020

jeherve merged commit 2c3dbd9 into master Jan 16, 2020

jeherve deleted the add/calendly-block branch January 16, 2020 14:37

matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jan 16, 2020

jeherve added [Status] Needs Testing We need to add this change to the testing call for this month's release [Status] Has Changelog and removed [Status] Needs Changelog [Status] Needs Testing We need to add this change to the testing call for this month's release labels Jan 16, 2020

jeherve added a commit that referenced this pull request Jan 17, 2020

Changelog: add #14252

462ebfa

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Blocks: Calendly block #14252

Blocks: Calendly block #14252

scruffian commented Dec 17, 2019 •

edited

Loading

jetpackbot commented Dec 17, 2019 •

edited

Loading

glendaviesnz commented Jan 9, 2020 •

edited

Loading

glendaviesnz commented Jan 9, 2020 •

edited

Loading

huguesvincent commented Jan 9, 2020

scruffian commented Jan 13, 2020

glendaviesnz commented Jan 13, 2020

jeherve left a comment

scruffian commented Jan 15, 2020 •

edited

Loading

jeherve left a comment

matticbot commented Jan 16, 2020

Blocks: Calendly block #14252

Blocks: Calendly block #14252

Conversation

scruffian commented Dec 17, 2019 • edited Loading

Changes proposed in this Pull Request:

Is this a new feature or does it add/remove features to an existing part of Jetpack?

Testing instructions:

Using Calendly

Proposed changelog entry for your changes:

jetpackbot commented Dec 17, 2019 • edited Loading

glendaviesnz commented Jan 9, 2020 • edited Loading

glendaviesnz commented Jan 9, 2020 • edited Loading

huguesvincent commented Jan 9, 2020

scruffian commented Jan 13, 2020

glendaviesnz commented Jan 13, 2020

jeherve left a comment

Choose a reason for hiding this comment

scruffian commented Jan 15, 2020 • edited Loading

jeherve left a comment

Choose a reason for hiding this comment

matticbot commented Jan 16, 2020

scruffian commented Dec 17, 2019 •

edited

Loading

jetpackbot commented Dec 17, 2019 •

edited

Loading

glendaviesnz commented Jan 9, 2020 •

edited

Loading

glendaviesnz commented Jan 9, 2020 •

edited

Loading

scruffian commented Jan 15, 2020 •

edited

Loading